Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow custom Meson CLI path #97

Merged
merged 2 commits into from
Aug 13, 2023
Merged

Allow custom Meson CLI path #97

merged 2 commits into from
Aug 13, 2023

Conversation

stefanv
Copy link
Member

@stefanv stefanv commented Aug 11, 2023

@rgommers This PR allows setting the Meson CLI in pyproject.toml. Do you think that would address NumPy's need?

@stefanv stefanv added the type: Enhancement New feature or request label Aug 11, 2023
@rgommers
Copy link
Contributor

Close I think. cli = 'path/to/custom/meson' still will not work on Windows, so I think we need a convention here that if cli ends in .py, then spin will prepend sys.executable` to the command.

@stefanv
Copy link
Member Author

stefanv commented Aug 11, 2023

Thanks, done.

@jarrodmillman jarrodmillman merged commit c5bf5f1 into scientific-python:main Aug 13, 2023
19 checks passed
@jarrodmillman jarrodmillman added this to the 0.5 milestone Aug 13, 2023
@rgommers
Copy link
Contributor

This looks good now - thanks for the release. I'll try this out later this week in numpy.

@rgommers rgommers mentioned this pull request Aug 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarrodmillman jarrodmillman jarrodmillman approved these changes

Assignees
No one assigned
Labels
type: Enhancement New feature or request
Projects
None yet
Milestone
0.5
Development

Successfully merging this pull request may close these issues.
3 participants
@stefanv @rgommers @jarrodmillman