fix: don't include paths starting with Windows drive letters as endpoints #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmhulbert
force-pushed
the
fix/endpointsOnWindows
branch
from
707a80f
to
b43c829
Compare
cmhulbert
force-pushed
the
fix/endpointsOnWindows
branch
from
b43c829
to
8736f5d
Compare
ctrueden
reviewed
Jul 17, 2022
jgo/jgo.py
Outdated
| @@ -265,7 +265,7 @@ def run_and_combine_outputs(command, *args): | |||
|
|
|||
| def find_endpoint(argv, shortcuts={}): | |||
| # endpoint is first positional argument | |||
| pattern = re.compile(".*https?://.*") | |||
| pattern = re.compile("(.*https?://.*|\S:\\.*)") | |||
There was a problem hiding this comment.
Is \S too general? I am not a Windows expert (especially the latest versions of Windows), but IIUC, you are limited to 26 drive letters A through Z. So better to use [A-Z] rather than \S, no?
There was a problem hiding this comment.
I think this is correct. I just pushed a change, to use [a-zA-Z] instead, since Windows paths aren't case sensitive. Thanks for taking a look at this!
|
Thanks @cmhulbert! And thanks @jayvdb for testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an argument passed to jgo starts with a windows drive letter (e.g. Z:\), it detects this as a valid endpoint, and the endpoint index is much farther than it otherwise should be. This results in the last positional arg jgo attempts to parse to receive all the extra arguments, that should have otherwise been passed to the program jgo is launching. In my case, it was passing these extra args to the
-rorrepositoryflag, and failing since the windows paths were not valid maven repositories.There already was present a check to ignore args that match
Endpoint.is_endpointbut containhttps://, so I added an additional check to ignore an arg starting with a windows drive letter when considering the endpoint index.