-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Jackson and dependents to 2.16.1 #256
Merged
ctrueden
merged 7 commits into
scijava:master
from
skalarproduktraum:bump-jackson-to-2.16.1
Feb 27, 2024
Merged
Bump Jackson and dependents to 2.16.1 #256
ctrueden
merged 7 commits into
scijava:master
from
skalarproduktraum:bump-jackson-to-2.16.1
Feb 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skalarproduktraum
force-pushed
the
bump-jackson-to-2.16.1
branch
from
February 21, 2024 09:09
c6e215c
to
7275782
Compare
Thanks @skalarproduktraum and sorry for the failing build. I force-pushed a commit before yours to this PR, which should hopefully resolve the build failure, which is unrelated to this change. |
ctrueden
force-pushed
the
bump-jackson-to-2.16.1
branch
4 times, most recently
from
February 21, 2024 19:45
7a66a78
to
943c991
Compare
Sad to say that this change does result in the dreaded
I'll try to make time to investigate soon... |
This replaces the org.codehaus.groovy:groovy dependency with org.apache.groovy:groovy, to avoid artifact clashes.
It is an unshaded uberjar bundling junit. Naughty.
ctrueden
added a commit
to scijava/pom-scijava-base
that referenced
this pull request
Feb 27, 2024
* extra-enforcer-rules: 1.2 -> 1.7.0 * scijava-maven-plugin: 2.2.0 -> 3.0.0 This update should pave the way for getting unstuck with some other downstream dependency version updates; see scijava/pom-scijava#256.
This upgrades the maven-enforcer-plugin component stack to play more nicely when updating components, particularly Jackson. In particular, this update fixes the following error in the mega-melt: Failed to execute goal org.apache.maven.plugins:maven-enforcer-plugin:3.3.0:enforce (enforce-rules) on project mega-melt: Execution enforce-rules of goal org.apache.maven.plugins:maven-enforcer-plugin:3.3.0:enforce failed. NullPointerException
ctrueden
force-pushed
the
bump-jackson-to-2.16.1
branch
from
February 27, 2024 21:32
734356e
to
4a28948
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps Jackson and its dependents to the current version, 2.16.1. It also removes the warning about not changing the version, as the issue seems to be gone with this new version.