Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Jackson and dependents to 2.16.1 #256

Merged
merged 7 commits into from
Feb 27, 2024

Conversation

skalarproduktraum
Copy link
Member

This PR bumps Jackson and its dependents to the current version, 2.16.1. It also removes the warning about not changing the version, as the issue seems to be gone with this new version.

@ctrueden
Copy link
Member

Thanks @skalarproduktraum and sorry for the failing build. I force-pushed a commit before yours to this PR, which should hopefully resolve the build failure, which is unrelated to this change.

@ctrueden ctrueden force-pushed the bump-jackson-to-2.16.1 branch 4 times, most recently from 7a66a78 to 943c991 Compare February 21, 2024 19:45
@ctrueden
Copy link
Member

Sad to say that this change does result in the dreaded NullPointerException in the maven-enforcer-plugin:

Failed to execute goal org.apache.maven.plugins:maven-enforcer-plugin:3.3.0:enforce (enforce-rules) on project mega-melt: Execution enforce-rules of goal org.apache.maven.plugins:maven-enforcer-plugin:3.3.0:enforce failed. NullPointerException -> [Help 1]

I'll try to make time to investigate soon...

ctrueden added a commit to scijava/pom-scijava-base that referenced this pull request Feb 27, 2024
* extra-enforcer-rules: 1.2 -> 1.7.0
* scijava-maven-plugin: 2.2.0 -> 3.0.0

This update should pave the way for getting unstuck with some other
downstream dependency version updates; see scijava/pom-scijava#256.
This upgrades the maven-enforcer-plugin component stack to play
more nicely when updating components, particularly Jackson.

In particular, this update fixes the following error in the mega-melt:

    Failed to execute goal
    org.apache.maven.plugins:maven-enforcer-plugin:3.3.0:enforce
    (enforce-rules) on project mega-melt: Execution enforce-rules of
    goal org.apache.maven.plugins:maven-enforcer-plugin:3.3.0:enforce
    failed. NullPointerException
@ctrueden ctrueden merged commit fe5801a into scijava:master Feb 27, 2024
1 check passed
@skalarproduktraum skalarproduktraum deleted the bump-jackson-to-2.16.1 branch March 26, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants