Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump imglib2-label-multisets #263

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

cmhulbert
Copy link
Contributor

@cmhulbert cmhulbert commented Apr 1, 2024

Add more functionality to LabelMultisetType and refactor serialization/deserialization. Fix a serialization related bug from 0.12.0

@ctrueden
Copy link
Member

ctrueden commented Apr 1, 2024

The n5-ij component failed in the melting pot, with error:

Error:    MetadataTests.testN5ViewerMetadata:140 discovery node count with single scale metadata expected:<4> but was:<0>

But when I try to reproduce the issue with mvn clean test -Dimglib2-label-multisets.version=0.13.0 in a local up-to-date clone of n5-ij, the tests all pass for me.

So I'm running the melting pot locally to see whether the failure happens for me that way.

@cmhulbert
Copy link
Contributor Author

Thanks @ctrueden , I also was not able to duplicate it locally when manually pulling in the version bump for n5-ij. Let me know if there is anything that needs to be done.

@ctrueden
Copy link
Member

ctrueden commented Apr 1, 2024

The melting pot all passed locally for me, so I'm going to merge this. Let's find out if the failure happens again! 😂

@ctrueden ctrueden merged commit 0424e37 into scijava:master Apr 1, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants