Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: docs build #471

Merged
merged 1 commit into from
Aug 21, 2023
Merged

fix: docs build #471

merged 1 commit into from
Aug 21, 2023

Conversation

LecrisUT
Copy link
Collaborator

@LecrisUT LecrisUT commented Aug 18, 2023

pypa/setuptools#4023 Fixes the issue

@henryiii
Copy link
Collaborator

Fixed for now in #473. We'll need to remember to uncap that when setuptools gets fixed.

@henryiii henryiii closed this Aug 21, 2023
@LecrisUT
Copy link
Collaborator Author

Can you check c5defb8? That's a different fix

@henryiii
Copy link
Collaborator

henryiii commented Aug 21, 2023

This didn't fix it? I see the same error in CI on this PR (previous run, when I reopen it, it will probably pass). Though, looking at it, I do think this is better that what is there currently, since this is actually not the package name, but the import name. Reopening.

@henryiii henryiii reopened this Aug 21, 2023
@LecrisUT
Copy link
Collaborator Author

LecrisUT commented Aug 21, 2023

Yeah, it's not a fix of the CI or anything, but just a leftover reference from when the project name got changed. This is not picked up by the CI because in all of them the project is built. (Although I'm not sure when this could be hit)

@henryiii
Copy link
Collaborator

It always was scikit-build-core, it's just a mixup confusing package name (which is normalized to dashes) with import name - and importlib uses import name. I assume this throws an import error and follows the alternate path always.

@LecrisUT
Copy link
Collaborator Author

Wait, but the project name in pyproject.toml is underscored. Doesn't it use the name from there?

@henryiii
Copy link
Collaborator

_, -, and . are required to be equivalent for packages. packaging.utils.canonicalize_name converts them to dashes. So in theory, you should be able to choose your display name with some backends based on what you put in pyproject.toml, but that's the only effect. It seems that hatchling normalizes early in the process, so the display name has dashes no matter what. (I've always thought of it with dashes, so would change it if hatching started respecting dashes and dots for metadata).

@LecrisUT
Copy link
Collaborator Author

I remember an issue where I had to convert dashes to underscores, probably in scikit-build, but maybe the issue was with the sdist archive and not with pypi or other

@henryiii
Copy link
Collaborator

Yeah, we had some issues with normalization. They should be fixed in 0.5. Metadata should now respect whatever you enter, and the sdist name should be normalized to underscores.

@henryiii henryiii merged commit 024ac32 into scikit-build:main Aug 21, 2023
@LecrisUT LecrisUT deleted the fix/ci branch March 28, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants