-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: docs build #471
fix: docs build #471
Conversation
Signed-off-by: Cristian Le <[email protected]>
Fixed for now in #473. We'll need to remember to uncap that when setuptools gets fixed. |
Can you check c5defb8? That's a different fix |
This didn't fix it? I see the same error in CI on this PR (previous run, when I reopen it, it will probably pass). Though, looking at it, I do think this is better that what is there currently, since this is actually not the package name, but the import name. Reopening. |
Yeah, it's not a fix of the CI or anything, but just a leftover reference from when the project name got changed. This is not picked up by the CI because in all of them the project is built. (Although I'm not sure when this could be hit) |
It always was scikit-build-core, it's just a mixup confusing package name (which is normalized to dashes) with import name - and importlib uses import name. I assume this throws an import error and follows the alternate path always. |
Wait, but the project name in |
|
I remember an issue where I had to convert dashes to underscores, probably in |
Yeah, we had some issues with normalization. They should be fixed in 0.5. Metadata should now respect whatever you enter, and the sdist name should be normalized to underscores. |
pypa/setuptools#4023 Fixes the issue