Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make fontsize same for experiment label and secondary label for ATLAS #531

Merged
merged 4 commits into from
Oct 24, 2024
Merged

fix: make fontsize same for experiment label and secondary label for ATLAS #531

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8762759
Make fontsize same for experiment label and secondary label for ATLAS
diptaparna Oct 23, 2024
173e0f0
adjusted further to match the heights
diptaparna Oct 24, 2024
8e64a6b
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Oct 24, 2024
d109b8b
updated reference image for pytest
diptaparna Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,8 @@ coverage.xml
*.cover
.hypothesis/
.pytest_cache/
flow_th1.root
result_images/
Comment on lines +52 to +53
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are these needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They get created when you run pytest.


# Translations
*.mo
Expand Down
4 changes: 2 additions & 2 deletions src/mplhep/label.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ def dist(tup):
transform=_t,
ha="left",
va=loc2_dict[loc]["va"],
fontsize=_font_size,
fontsize=_font_size * 1.2 if exp == "ATLAS" else _font_size,
fontname=fontname,
fontstyle="italic" if italic[1] else "normal",
)
Expand Down Expand Up @@ -329,7 +329,7 @@ def exp_label(
fontname : string, optional
Name of font to be used.
fontsize : string, optional
Defines size of "secondary label". Experiment label is 1.3x larger.
Defines size of the experiment label and the secondary label.
exp_weight : string, optional
Set fontweight of <exp> label. Default "bold".
italic : (bool, bool, bool), optional
Expand Down
Binary file modified tests/baseline/test_style_atlas.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading