Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do not overwrite rwgt weights with weights weights #231

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

APN-Pucky
Copy link
Member

@APN-Pucky APN-Pucky commented Feb 20, 2024

Hotfix for #230
Closes: #230

@APN-Pucky APN-Pucky force-pushed the patch-1 branch 2 times, most recently from 89861d4 to cfd6b76 Compare February 20, 2024 14:42
@APN-Pucky APN-Pucky changed the title Do not overwrite rwgt weights with weights weights fix: Do not overwrite rwgt weights with weights weights Feb 20, 2024
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.91%. Comparing base (584c03f) to head (00b6dac).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #231      +/-   ##
==========================================
+ Coverage   91.48%   91.91%   +0.42%     
==========================================
  Files           2        2              
  Lines         235      235              
  Branches       54       54              
==========================================
+ Hits          215      216       +1     
  Misses         16       16              
+ Partials        4        3       -1     
Flag Coverage Δ
unittests-3.10 91.48% <100.00%> (+0.42%) ⬆️
unittests-3.8 91.48% <100.00%> (+0.42%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewfeickert matthewfeickert merged commit aefb63b into scikit-hep:main Mar 20, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: rwgt overwritten by weights
2 participants