Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix : Issue in readMe file link not working #536

Closed
wants to merge 2 commits into from

Conversation

Ankush1oo8
Copy link
Contributor

Description

Kindly take a look at CONTRIBUTING.md.

Please describe the purpose of this pull request. Reference and link to any relevant issues or pull requests.

Checklist

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't any other open Pull Requests for the required change?
  • Does your submission pass pre-commit? ($ pre-commit run --all-files or $ nox -s lint)
  • Does your submission pass tests? ($ pytest or $ nox -s tests)
  • Does the documentation build with your changes? ($ cd docs; make clean; make html or $ nox -s docs)
  • Does your submission pass the doctests? ($ pytest --doctest-plus src/vector/ or $ nox -s doctests)

Before Merging

fixed issue #535
the link in readme file was not working

In README, the link to coffea.nanoevents.methods.vector doesn't work. The current link in the github will be linked to 404 page.

updated to

..., and coffea.nanoevents.methods.vector (backed by Scikit-HEP/vector since v2024.8).

  • Summarize the commit messages into a brief review of the Pull request.

Copy link
Member

@Saransh-cpp Saransh-cpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Ankush1oo8!

@Saransh-cpp
Copy link
Member

The tests are failing because of dask-contrib/dask-awkward#557. I'll merge this given that this PR only changes the README.

Copy link
Member

@Saransh-cpp Saransh-cpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Saransh-cpp
Copy link
Member

Could you also please create a PR from a non-main branch? Thanks!

@Ankush1oo8
Copy link
Contributor Author

Okey I will update the other file and make a pr from other branch

@Ankush1oo8 Ankush1oo8 closed this Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants