Skip to content

Commit

Permalink
Fix spelling and grammar errors in README.md (#110)
Browse files Browse the repository at this point in the history
* Fix spelling and grammar errors in README.md

- deviding -> dividing
- initialisation -> initialization
- max tend -> max tends
- utilising -> utilizing

* Apply suggestion

- Changed z->s to use the British spelling
  • Loading branch information
arsenkhy authored Jul 25, 2022
1 parent af93034 commit f783995
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ reason the first step of correction is the widely used Benjamini Hochberg FDR.
Following that however we also need to account for the fact that we have been
testing the same features over and over again in each iteration with the
same test. For this scenario the Bonferroni is perfect, so it is applied by
deviding the p-value threshold with the current iteration index.
dividing the p-value threshold with the current iteration index.

If this two step correction is not required, the two_step parameter has to be
set to False, then (with perc=100) BorutaPy behaves exactly as the R version.
Expand All @@ -134,7 +134,7 @@ __n_estimators__ : int or string, default = 1000
__perc__ : int, default = 100
> Instead of the max we use the percentile defined by the user, to pick
> our threshold for comparison between shadow and real features. The max
> tend to be too stringent. This provides a finer control over this. The
> tends to be too stringent. This provides a finer control over this. The
> lower perc is the more false positives will be picked as relevant but
> also the less relevant features will be left out. The usual trade-off.
> The default is essentially the vanilla Boruta corresponding to the max.
Expand Down

0 comments on commit f783995

Please sign in to comment.