Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_find_neighbor_and_lambda off-by-one error #425

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ainkov
Copy link

@ainkov ainkov commented Nov 5, 2020

Hi there, I believe there is an off-by-one error in taking the point to predict core distance.
Currently it's taking the 6th neighbor (if min_samples is 5) as the core distance.
It's what solved my issue in #381 , although you are the best to judge whether it's logically correct depending on the rest of the implementation.
Thanks and regards.

@pep8speaks
Copy link

Hello @ainkov, Thank you for submitting the Pull Request !

Line 139:21: W503 line break before binary operator
Line 247:22: W503 line break before binary operator
Line 308:44: W503 line break before binary operator
Line 310:56: W503 line break before binary operator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants