Support p values other than 2 for minkowski #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Suggested quick fix to use p values other than 2 for minkowski. Setting _metric_kwargs in __init__ is for use in generate_prediction_data() and weighted_cluster_medoid()
|
This seems to break the boruvka KDTrees, which don't seem to support taking a p value. You may need a further workaround (use ball trees) in that case. |
|
Thanks for the info. Will set up a new environment and find out why it fails in newer versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested quick fix to use p values other than 2 for minkowski. Setting _metric_kwargs in init is for use in generate_prediction_data() and weighted_cluster_medoid().