-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speed tweaks for Robust algorithms & make examples faster #77
Merged
TimotheeMathieu
merged 23 commits into
scikit-learn-contrib:master
from
TimotheeMathieu:robust
Nov 16, 2020
Merged
Speed tweaks for Robust algorithms & make examples faster #77
TimotheeMathieu
merged 23 commits into
scikit-learn-contrib:master
from
TimotheeMathieu:robust
Nov 16, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ustering. Update doc, test, examples. Fix typo
Added: cython code for kmeans loss (modified from sklearn implementation), significant speedup for |
TimotheeMathieu
changed the title
Make stopping criterion for Robust algorithms
Speed tweaks for Robust algorithms
Nov 14, 2020
TimotheeMathieu
changed the title
Speed tweaks for Robust algorithms
Speed tweaks for Robust algorithms & make examples faster
Nov 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following issue #76 .
I added the same stopping criterion as for sklearn's SGDClassifier/SGDRegressor (i.e. stop if the loss does not change after n_iter_no_change steps). I also sub-sampled the California houses dataset example and clustering example.
Result :
On a recent CPU.
Is it sufficient or should I find examples that are faster to run ?