-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bugs in robust module and improve test coverage #78
Fix bugs in robust module and improve test coverage #78
Conversation
…ustering. Update doc, test, examples. Fix typo
@rth the PR is ready for review, thanks in advance. For now I removed the real data classification example as I didn't find a good example to replace the last one that had some problems. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @TimotheeMathieu ! Generally looks good to me aside for the two following comments.
Co-authored-by: Roman Yurchak <[email protected]>
I fixed the test for kmedoids here mentioned in PR #73 EDIT : I removed the test in order to make a separate PR. |
@rth I don't understand the error in azure pipeline for python 3.9. |
The The scikit-learn pre-release also supports py3.9 already. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I won't be able to do a detailed review, but generally looks good to me. Thanks!
Feel free to merge once CI is green.
Co-authored-by: Roman Yurchak <[email protected]>
In PR #76 I succeeded in making examples faster but as a consequence some of the examples do not work anymore.
It allowed me to see some bugs in the robust module and this PR is to resolve them and try to improve the test in order not to encounter this situation again.
TODO:
If anyone has a test suggestion, please share in comment.