Skip to content

Commit

Permalink
mm remarks
Browse files Browse the repository at this point in the history
  • Loading branch information
Badr-MOUFAD committed Oct 25, 2023
1 parent 96269ce commit 8194a41
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 5 deletions.
1 change: 0 additions & 1 deletion skglm/datafits/multi_task.py
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ def get_lipschitz(self, X, Y):
return lipschitz

def get_lipschitz_sparse(self, X_data, X_indptr, X_indices, Y):
"""Pre-computations before fitting on X and Y, when X is sparse."""
n_samples, n_tasks = Y.shape
n_features = len(X_indptr) - 1

Expand Down
4 changes: 2 additions & 2 deletions skglm/solvers/anderson_cd.py
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,7 @@ def _cd_epoch(X, y, w, Xw, lc, datafit, penalty, ws):
Model fit.
lc : array, shape (n_features,)
Lipschitz constants of the features.
Coordinatewise gradient Lipschitz constants.
datafit : Datafit
Datafit.
Expand Down Expand Up @@ -332,7 +332,7 @@ def _cd_epoch_sparse(X_data, X_indptr, X_indices, y, w, Xw, lc, datafit, penalty
Model fit.
lc : array, shape (n_features,)
Lipschitz constants of the features.
Coordinatewise gradient Lipschitz constants.
datafit : Datafit
Datafit.
Expand Down
2 changes: 1 addition & 1 deletion skglm/solvers/common.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ def dist_fix_point(w, grad_ws, lipschitz, datafit, penalty, ws):
Gradient restricted to the working set.
lipschitz : array, shape (n_features,)
Lipschitz constants of the features.
Coordinatewise gradient Lipschitz constants.
datafit: instance of BaseDatafit
Datafit.
Expand Down
1 change: 0 additions & 1 deletion skglm/solvers/multitask_bcd.py
Original file line number Diff line number Diff line change
Expand Up @@ -366,7 +366,6 @@ def _bcd_epoch(X, Y, W, XW, lc, datafit, penalty, ws):
lc : array, shape (n_features,)
Lipschitz constants of each bloc.
datafit : instance of BaseMultiTaskDatafit
Datafit.
Expand Down

0 comments on commit 8194a41

Please sign in to comment.