Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT - Refactor dist_fix_point function #194

Merged
merged 2 commits into from
Oct 31, 2023
Merged

MNT - Refactor dist_fix_point function #194

merged 2 commits into from
Oct 31, 2023

Conversation

Badr-MOUFAD
Copy link
Collaborator

@Badr-MOUFAD Badr-MOUFAD commented Oct 26, 2023 •
edited
Loading

Context of the PR

As pointed out by #193, this gives an appropriate name to dist_fix_point function.

Contributions of the PR

  • rename dist_fix_point ---> dist_fix_point_cd for CD solver
  • rename dist_fix_point ---> dist_fix_point_bcd for BCD solver
  • enhance the implementation of the function

Checks before merging PR

  • added documentation for any new feature
  • [ ] added unittests
  • [ ] edited the what's new

@Badr-MOUFAD Badr-MOUFAD requested a review from mathurinm October 26, 2023 11:44
@Badr-MOUFAD Badr-MOUFAD linked an issue Oct 30, 2023 that may be closed by this pull request
MNT - Rename dist_fix_point to dist_fix_point_cd #193
Closed
@mathurinm mathurinm mentioned this pull request Oct 30, 2023
Open
6 tasks
@Badr-MOUFAD Badr-MOUFAD merged commit 59f91f7 into scikit-learn-contrib:main Oct 31, 2023
2 checks passed
@Badr-MOUFAD Badr-MOUFAD deleted the mv-dist_fix_point branch October 31, 2023 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathurinm mathurinm mathurinm approved these changes

Assignees
No one assigned
Labels
Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MNT - Rename dist_fix_point to dist_fix_point_cd
2 participants
@Badr-MOUFAD @mathurinm