Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX - Upload documentation only when merging to main #209

Merged
merged 4 commits into from
Dec 12, 2023

Conversation

Badr-MOUFAD
Copy link
Collaborator

Context of the PR

Follow up on #206,
In Circleci jobs, the last instructions aren't meant to run if we merge to main

# Add stable documentation
- run:
name: stable_doc
command: |
set -e
mkdir -p ~/.ssh
echo -e "Host *\nStrictHostKeyChecking no" > ~/.ssh/config
chmod og= ~/.ssh/config
cd doc;
make add-stable-doc

since these are already performed in the Deploy step.

Therefore the CI fails (although everything is fine)

Contributions of the PR

  • upload documentation to gh-pages if the branch is main

Checks before merging PR

  • [ ] added documentation for any new feature
  • [ ] added unittests
  • [ ] edited the what's new

@Badr-MOUFAD Badr-MOUFAD changed the title FIX - Upload documentation when merging to main FIX - Upload documentation only when merging to main Nov 14, 2023
@mathurinm mathurinm merged commit 43d0585 into scikit-learn-contrib:main Dec 12, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants