-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand testing #751
Merged
Merged
Expand testing #751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #751 +/- ##
==========================================
+ Coverage 59.62% 61.99% +2.37%
==========================================
Files 16 16
Lines 3160 3160
==========================================
+ Hits 1884 1959 +75
+ Misses 1276 1201 -75 ☔ View full report in Codecov by Sentry. |
mmghannam
reviewed
Nov 17, 2023
mmghannam
reviewed
Nov 17, 2023
mmghannam
reviewed
Nov 17, 2023
mmghannam
reviewed
Nov 17, 2023
mmghannam
reviewed
Nov 17, 2023
mmghannam
reviewed
Nov 17, 2023
mmghannam
reviewed
Nov 17, 2023
mmghannam
reviewed
Nov 17, 2023
mmghannam
reviewed
Nov 17, 2023
mmghannam
reviewed
Nov 17, 2023
mmghannam
reviewed
Nov 17, 2023
mmghannam
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some notes and questions.
There is no method to check whether a solution has been freed. If we try to
setSolVal
in a freed solution, we get a segfault.addConsLocal
appears to still be causing issues.addConsIndicator
appears to still be causing issues when the binary variable isI think logical constraints were already tested in
test_logical.py
, but the syntax is completely different from the rest of the tests.Should we treat the tests as a potential tutorial? I know I used
test_pricer.py
to know how a pricer works, but I've now added some methods there (getNSolsFound
,getNBestSolsFound
,getNSols
) just to test them, and I worry that new users would find it weird. In my opinion, we should greatly expand the tutorial folder, and assume that the tests will not be accessed by regular users.