Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand testing #751

Merged
merged 18 commits into from
Nov 17, 2023
Merged

Expand testing #751

merged 18 commits into from
Nov 17, 2023

Conversation

Joao-Dionisio
Copy link
Collaborator

@Joao-Dionisio Joao-Dionisio commented Nov 16, 2023

Some notes and questions.

There is no method to check whether a solution has been freed. If we try to setSolVal in a freed solution, we get a segfault.

addConsLocal appears to still be causing issues.

addConsIndicator appears to still be causing issues when the binary variable is $0$. Should we add tests that we know will fail because the methods are wrong?

I think logical constraints were already tested in test_logical.py, but the syntax is completely different from the rest of the tests.

Should we treat the tests as a potential tutorial? I know I used test_pricer.py to know how a pricer works, but I've now added some methods there (getNSolsFound, getNBestSolsFound, getNSols) just to test them, and I worry that new users would find it weird. In my opinion, we should greatly expand the tutorial folder, and assume that the tests will not be accessed by regular users.

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (14c8486) 59.62% compared to head (22341f0) 61.99%.

❗ Current head 22341f0 differs from pull request most recent head d71dd2e. Consider uploading reports for the commit d71dd2e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #751      +/-   ##
==========================================
+ Coverage   59.62%   61.99%   +2.37%     
==========================================
  Files          16       16              
  Lines        3160     3160              
==========================================
+ Hits         1884     1959      +75     
+ Misses       1276     1201      -75     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tests/test_cons.py Outdated Show resolved Hide resolved
tests/test_cons.py Outdated Show resolved Hide resolved
tests/test_cons.py Outdated Show resolved Hide resolved
tests/test_solution.py Outdated Show resolved Hide resolved
tests/test_solution.py Outdated Show resolved Hide resolved
tests/test_cons.py Outdated Show resolved Hide resolved
tests/test_cons.py Outdated Show resolved Hide resolved
tests/test_cons.py Outdated Show resolved Hide resolved
tests/test_cons.py Outdated Show resolved Hide resolved
tests/test_cons.py Outdated Show resolved Hide resolved
@mmghannam mmghannam merged commit 16c229d into master Nov 17, 2023
@Joao-Dionisio Joao-Dionisio deleted the expand_testing branch April 3, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants