Merge branch 'fix-strong-branching' into 'v91-bugfix'

Fix strongbranching cutoffs See merge request integer/scip!3534
scipopt · Oct 10, 2024 · 36c553d · 36c553d
2 parents 16e5da5 + 40f77c4
commit 36c553d
Show file tree

Hide file tree

Showing 5 changed files with 35 additions and 34 deletions.
diff --git a/src/scip/branch_allfullstrong.c b/src/scip/branch_allfullstrong.c
@@ -104,10 +104,6 @@ SCIP_RETCODE branch(
    int npseudocands;
    int npriopseudocands;
    int bestpseudocand;
-#ifndef NDEBUG
-   SCIP_Real cutoffbound;
-   cutoffbound = SCIPgetCutoffbound(scip);
-#endif
 
    assert(branchrule != NULL);
    assert(strcmp(SCIPbranchruleGetName(branchrule), BRANCHRULE_NAME) == 0);
@@ -165,7 +161,7 @@ SCIP_RETCODE branch(
 
          assert(*result == SCIP_DIDNOTRUN);
          assert(0 <= bestpseudocand && bestpseudocand < npseudocands);
-         assert(SCIPisLT(scip, provedbound, cutoffbound));
+         assert(SCIPisLT(scip, provedbound, SCIPgetCutoffbound(scip)));
 
          var = pseudocandscopy[bestpseudocand];
 
@@ -316,10 +312,6 @@ SCIP_RETCODE SCIPselectVarPseudoStrongBranching(
    SCIP_Real lpobjval;
    SCIP_Bool allcolsinlp;
    SCIP_Bool exactsolve;
-#ifndef NDEBUG
-   SCIP_Real cutoffbound;
-   cutoffbound = SCIPgetCutoffbound(scip);
-#endif
 
    assert(scip != NULL);
    assert(pseudocands != NULL);
@@ -442,8 +434,8 @@ SCIP_RETCODE SCIPselectVarPseudoStrongBranching(
          up = MAX(up, lpobjval);
          downgain = down - lpobjval;
          upgain = up - lpobjval;
-         assert(!allcolsinlp || exactsolve || !downvalid || downinf == SCIPisGE(scip, down, cutoffbound));
-         assert(!allcolsinlp || exactsolve || !upvalid || upinf == SCIPisGE(scip, up, cutoffbound));
+         assert(!allcolsinlp || exactsolve || !downvalid || downinf == SCIPisGE(scip, down, SCIPgetCutoffbound(scip)));
+         assert(!allcolsinlp || exactsolve || !upvalid || upinf == SCIPisGE(scip, up, SCIPgetCutoffbound(scip)));
          assert(downinf || !downconflict);
          assert(upinf || !upconflict);
 

diff --git a/src/scip/scip_prob.c b/src/scip/scip_prob.c
@@ -3724,7 +3724,9 @@ SCIP_RETCODE SCIPupdateLocalLowerbound(
 }
 
 /** if given value is tighter (higher for minimization, lower for maximization) than the node's dual bound, sets the
- *  node's dual bound to the new value. Only applicable to non-leafs because the node priority queue remains untouched.
+ *  node's dual bound to the new value.
+ *
+ *  @note must not be used on a leaf because the node priority queue remains untouched
  *
  *  @return \ref SCIP_OKAY is returned if everything worked. Otherwise a suitable error code is passed. See \ref
  *          SCIP_Retcode "SCIP_RETCODE" for a complete list of error codes.
@@ -3746,7 +3748,9 @@ SCIP_RETCODE SCIPupdateNodeDualbound(
 }
 
 /** if given value is higher than the node's lower bound (in transformed problem), sets the node's lower bound to the
- *  new value. Only applicable to non-leafs because the node priority queue remains untouched.
+ *  new value.
+ *
+ *  @note must not be used on a leaf because the node priority queue remains untouched
  *
  *  @return \ref SCIP_OKAY is returned if everything worked. Otherwise a suitable error code is passed. See \ref
  *          SCIP_Retcode "SCIP_RETCODE" for a complete list of error codes.

diff --git a/src/scip/scip_tree.c b/src/scip/scip_tree.c
@@ -424,6 +424,8 @@ SCIP_RETCODE SCIPgetOpenNodesData(
 }
 
 /** cuts off node and whole sub tree from branch and bound tree
+ *
+ *  @note must not be used on a leaf because the node priority queue remains untouched
  *
  *  @return \ref SCIP_OKAY is returned if everything worked. Otherwise a suitable error code is passed. See \ref
  *          SCIP_Retcode "SCIP_RETCODE" for a complete list of error codes.

diff --git a/src/scip/scip_var.c b/src/scip/scip_var.c
@@ -2946,7 +2946,7 @@ SCIP_RETCODE SCIPgetVarStrongbranchFrac(
 
    assert(var != NULL);
    assert(lperror != NULL);
-   assert(!SCIPtreeProbing(scip->tree)); /* we should not be in strong branching with propagation mode */
+   assert(!SCIPinProbing(scip)); /* we should not be in strong branching with propagation mode */
    assert(var->scip == scip);
 
    SCIP_CALL( SCIPcheckStage(scip, "SCIPgetVarStrongbranchFrac", FALSE, FALSE, FALSE, FALSE, FALSE, FALSE, FALSE, TRUE, FALSE, TRUE, FALSE, FALSE, FALSE, FALSE) );
@@ -3044,15 +3044,13 @@ SCIP_RETCODE SCIPgetVarStrongbranchFrac(
    {
       if( !idempotent ) /*lint !e774*/
       {
-         SCIP_CALL( analyzeStrongbranch(scip, var, downinf, upinf, downconflict, upconflict) );
-      }
-      else
-      {
-         if( downinf != NULL )
-            *downinf = localdownvalid && SCIPsetIsGE(scip->set, localdown, scip->lp->cutoffbound);
-         if( upinf != NULL )
-            *upinf = localupvalid && SCIPsetIsGE(scip->set, localup, scip->lp->cutoffbound);
+         SCIP_CALL( analyzeStrongbranch(scip, var, NULL, NULL, downconflict, upconflict) );
       }
+
+      if( downinf != NULL )
+         *downinf = localdownvalid && SCIPsetIsGE(scip->set, localdown, scip->lp->cutoffbound);
+      if( upinf != NULL )
+         *upinf = localupvalid && SCIPsetIsGE(scip->set, localup, scip->lp->cutoffbound);
    }
 
    if( down != NULL )
@@ -3766,11 +3764,12 @@ SCIP_RETCODE SCIPgetVarStrongbranchInt(
    SCIP_Bool localdownvalid;
    SCIP_Bool localupvalid;
 
-   SCIP_CALL( SCIPcheckStage(scip, "SCIPgetVarStrongbranchInt", FALSE, FALSE, FALSE, FALSE, FALSE, FALSE, FALSE, TRUE, FALSE, TRUE, FALSE, FALSE, FALSE, FALSE) );
-
+   assert(var != NULL);
    assert(lperror != NULL);
    assert(var->scip == scip);
 
+   SCIP_CALL( SCIPcheckStage(scip, "SCIPgetVarStrongbranchInt", FALSE, FALSE, FALSE, FALSE, FALSE, FALSE, FALSE, TRUE, FALSE, TRUE, FALSE, FALSE, FALSE, FALSE) );
+
    lpobjval = SCIPgetLPObjval(scip);
    if( downvalid != NULL )
       *downvalid = FALSE;
@@ -3864,15 +3863,13 @@ SCIP_RETCODE SCIPgetVarStrongbranchInt(
    {
       if( !idempotent ) /*lint !e774*/
       {
-         SCIP_CALL( analyzeStrongbranch(scip, var, downinf, upinf, downconflict, upconflict) );
-      }
-      else
-      {
-         if( downinf != NULL )
-            *downinf = localdownvalid && SCIPsetIsGE(scip->set, localdown, scip->lp->cutoffbound);
-         if( upinf != NULL )
-            *upinf = localupvalid && SCIPsetIsGE(scip->set, localup, scip->lp->cutoffbound);
+         SCIP_CALL( analyzeStrongbranch(scip, var, NULL, NULL, downconflict, upconflict) );
       }
+
+      if( downinf != NULL )
+         *downinf = localdownvalid && SCIPsetIsGE(scip->set, localdown, scip->lp->cutoffbound);
+      if( upinf != NULL )
+         *upinf = localupvalid && SCIPsetIsGE(scip->set, localup, scip->lp->cutoffbound);
    }
 
    if( down != NULL )

diff --git a/src/scip/tree.c b/src/scip/tree.c
@@ -1231,7 +1231,10 @@ SCIP_RETCODE SCIPnodeFree(
    return SCIP_OKAY;
 }
 
-/** cuts off node and whole sub tree from branch and bound tree */
+/** cuts off node and whole sub tree from branch and bound tree
+ *
+ *  @note must not be used on a leaf because the node priority queue remains untouched
+ */
 SCIP_RETCODE SCIPnodeCutoff(
    SCIP_NODE*            node,               /**< node that should be cut off */
    SCIP_SET*             set,                /**< global SCIP settings */
@@ -2377,7 +2380,10 @@ SCIP_RETCODE treeApplyPendingBdchgs(
    return SCIP_OKAY;
 }
 
-/** if given value is larger than the node's lower bound, sets the node's lower bound to the new value */
+/** if given value is larger than the node's lower bound, sets the node's lower bound to the new value
+ *
+ *  @note must not be used on a leaf because the node priority queue remains untouched
+ */
 void SCIPnodeUpdateLowerbound(
    SCIP_NODE*            node,               /**< node to update lower bound for */
    SCIP_STAT*            stat,               /**< problem statistics */