Skip to content

Commit

Permalink
remove -Wctor-dtor-privacy for soplex
Browse files Browse the repository at this point in the history
- soplex seems to have decided to include the fmt library
- when compiling lpi_spx2, the fmt header (included by soplex.h) needs to
  be compiled now
- however, fmt headers generate ctor-dtor-privacy warning
- as in integer/soplex@d377249db958aa16a6e539bbc1324188066c877f, this
  change removes checking for this warning
  • Loading branch information
svigerske committed Sep 9, 2023
1 parent ff373a6 commit b4c4c69
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ endif()
# if changing these flags, also update GCCWARN/GXXWARN in make/make.project
set(ADD_C_AND_CXX_FLAGS -pedantic -Wall -W -Wpointer-arith -Wcast-align -Wwrite-strings -Wshadow -Wredundant-decls -Wdisabled-optimization -Wno-long-long -Wno-unknown-pragmas -Wno-unused-parameter)
set(ADD_C_FLAGS -Wsign-compare -Wstrict-prototypes -Wmissing-declarations -Wmissing-prototypes -Wno-override-init -Wno-uninitialized -Wno-maybe-uninitialized)
set(ADD_CXX_FLAGS -Wctor-dtor-privacy -Wnon-virtual-dtor -Wreorder -Woverloaded-virtual -Wsign-promo -Wsynth -Wcast-qual -Wno-strict-overflow -Wno-psabi)
set(ADD_CXX_FLAGS -Wnon-virtual-dtor -Wreorder -Woverloaded-virtual -Wsign-promo -Wsynth -Wcast-qual -Wno-strict-overflow -Wno-psabi)

if(CMAKE_CXX_COMPILER_ID MATCHES "Clang")
# clang specific suppressions
Expand Down
2 changes: 1 addition & 1 deletion make/make.project
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ GXXWARN = -pedantic -Wall -W
GCCWARN += -Wpointer-arith -Wcast-align -Wwrite-strings -Wshadow -Wredundant-decls -Wdisabled-optimization \
-Wsign-compare -Wstrict-prototypes -Wmissing-declarations -Wmissing-prototypes
GXXWARN += -Wpointer-arith -Wcast-align -Wwrite-strings -Wshadow -Wredundant-decls -Wdisabled-optimization \
-Wctor-dtor-privacy -Wnon-virtual-dtor -Wreorder -Woverloaded-virtual -Wsign-promo -Wsynth -Wcast-qual
-Wnon-virtual-dtor -Wreorder -Woverloaded-virtual -Wsign-promo -Wsynth -Wcast-qual

# disable some warning that would be too much effort to fix, disfigure the code, or produce too many false positive
GCCWARN += -Wno-long-long -Wno-unknown-pragmas -Wno-unused-parameter -Wno-override-init -Wno-uninitialized -Wno-maybe-uninitialized
Expand Down

0 comments on commit b4c4c69

Please sign in to comment.