Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add node.js 20 #400

Merged
merged 28 commits into from
Sep 6, 2023
Merged

Add node.js 20 #400

merged 28 commits into from
Sep 6, 2023

Conversation

hhorak
Copy link
Member

@hhorak hhorak commented Aug 11, 2023

I'd like to wait for node.js 20 being in CentOS Stream 8 and 9 before merging, it should be every day....

@hhorak hhorak marked this pull request as draft August 11, 2023 08:25
@hhorak
Copy link
Member Author

hhorak commented Aug 11, 2023

I still need to change Makefile and add .exclude* or *.devel files.

@hhorak
Copy link
Member Author

hhorak commented Aug 16, 2023

[test]

@hhorak
Copy link
Member Author

hhorak commented Aug 16, 2023

@phracek If you could check whether I remembered to change all config files that should be changed (github actions and others), it would be great.

@hhorak
Copy link
Member Author

hhorak commented Aug 16, 2023

@phracek I forgot that the changes in config files should be added in a separate file, I'll do that.

@hhorak hhorak force-pushed the addnodejs20 branch 2 times, most recently from a2ae604 to d94ecc8 Compare August 17, 2023 16:19
@hhorak
Copy link
Member Author

hhorak commented Aug 17, 2023

[test]

@hhorak
Copy link
Member Author

hhorak commented Aug 21, 2023

[test]

@hhorak
Copy link
Member Author

hhorak commented Aug 21, 2023

[test]

@hhorak hhorak mentioned this pull request Aug 21, 2023
Merged
@hhorak
Copy link
Member Author

hhorak commented Aug 21, 2023

[test]

1 similar comment
@hhorak
Copy link
Member Author

hhorak commented Aug 22, 2023

[test]

@hhorak
Copy link
Member Author

hhorak commented Aug 22, 2023

fastify test failure reported as #391
express and cloudevents failures reported as #404

@hhorak hhorak mentioned this pull request Aug 23, 2023
Merged
@hhorak
Copy link
Member Author

hhorak commented Aug 23, 2023

[test]

@hhorak
Copy link
Member Author

hhorak commented Aug 23, 2023

[test]

1 similar comment
@hhorak
Copy link
Member Author

hhorak commented Aug 23, 2023

[test]

@hhorak hhorak marked this pull request as ready for review August 23, 2023 19:05
phracek
phracek requested changes Aug 28, 2023
View reviewed changes
20-minimal/Dockerfile.c9s Outdated Show resolved Hide resolved
18-minimal/Dockerfile.fedora Outdated Show resolved Hide resolved
20-minimal/Dockerfile.c8s Outdated Show resolved Hide resolved
@hhorak
Copy link
Member Author

hhorak commented Aug 28, 2023

[test]

1 similar comment
@hhorak
Copy link
Member Author

hhorak commented Aug 28, 2023

[test]

@hhorak hhorak changed the title [Draft] Add node.js 20 Add node.js 20 Aug 28, 2023
@hhorak
Copy link
Member Author

hhorak commented Aug 29, 2023

[test]

hhorak added 18 commits August 30, 2023 17:41
@hhorak
Add v20 to the root README.md
006aa46
@hhorak
Add v20 to build-push action config
0a41328
@hhorak
Add CentOS Stream composes to have the newly built Node.js 20
07f89a2
@hhorak
Remove duplicit which package
14ed37f
@hhorak
Add v20 to Makefile
508d151
@hhorak
Some upstream tests fail with the newest version, let's mark them uns…
67da291 
…table
@hhorak
Revert a wrong s/18/20/ replacement in the i18n package name
8410055
@hhorak
Be explicit about where to get ubi8/ image
30e5da8
@hhorak
Remove duplicate line in 18-minimal/Dockerfile.fedora
3a5db59
@hhorak
Use updated common that allows to build/tag non-minimal version as well
339458e
@hhorak
Be more clever about guessing FULL_IMAGE name
6ce177b
@hhorak
Add fixed minimal variants for Fedora
897398d
@hhorak
Fix Fedora dockerfiles to build fine
4300b13
@hhorak
Fix CentOS Stream builds
08a6961
@hhorak
Fix Fedora dockerfiles and update to F38
34919ee
@hhorak
Sync assemble of 20 with 20-minimal
1f48765 
This makes the cache clearning working, otherwise the
 command creates some debug log inside of
after the  is cleared. That makes the test test_npm_cache_cleared
to fail.
@hhorak
Mark the failing clients tests unstable and ignore their result
ef0743e
@hhorak
Mark faas client test unstable on v14
64a310c 
Failed in http://artifacts.osci.redhat.com/testing-farm/c0910ae7-f0fe-4aed-a829-801476b37b88/
@hhorak
Copy link
Member Author

hhorak commented Aug 30, 2023

[test]

@hhorak
Copy link
Member Author

hhorak commented Aug 31, 2023

@phracek yay, the tests are green, I've specifically made the unstable tests ignored. if you're ok with this change and don't see any further issues, what if we merge and solve the potential remaining issues later?

phracek
phracek requested changes Sep 5, 2023
View reviewed changes
Copy link
Member

@phracek phracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address my comments or provide me an explanation.

18-minimal/Dockerfile.c8s Show resolved Hide resolved
18-minimal/Dockerfile.c8s Show resolved Hide resolved
18-minimal/Dockerfile.c9s Show resolved Hide resolved
18-minimal/Dockerfile.fedora Outdated Show resolved Hide resolved
20-minimal/.devel-repo-rhel8 Outdated Show resolved Hide resolved
20-minimal/.devel-repo-rhel9 Outdated Show resolved Hide resolved
20-minimal/Dockerfile.c8s Show resolved Hide resolved
20-minimal/Dockerfile.c9s Show resolved Hide resolved
20/.devel-repo-rhel9 Outdated Show resolved Hide resolved
20/.devel-repo-rhel8 Outdated Show resolved Hide resolved
@phracek
Copy link
Member

phracek commented Sep 6, 2023

[test-all]

@hhorak
Revert "Remove devel files, they are added automatically now"
4989bbb 
This reverts commit edcd6e9.
After syncing with phracek, automatic addition of devel repos is broken,
let's add them temporarily until it's fixed.
@hhorak
Remove temporary copr repos, correct nodemon is already available off…
754228a 
…icially
@hhorak
Copy link
Member Author

hhorak commented Sep 6, 2023

[test]

phracek
phracek approved these changes Sep 6, 2023
View reviewed changes
Copy link
Member

@phracek phracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for investigation and solving issue with new nodejs-20 version. Everything is passing properly. Let's get merge it. Super hard work.

@phracek phracek merged commit 4ed2ea6 into sclorg:master Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phracek phracek phracek approved these changes

Assignees
No one assigned
Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hhorak @phracek