Feature/validation #29
Conversation
…me refactoring to the code
…lass with base methods
|
Hi @rogervinas my changes are in the last commit. I tag you in the commit but apparently github did not notify to you(Sorry I am more a gitlab guy). If you have any doubt just tell me. Bests |
|
|
||
| public TweetService(EntityManager entityManager, MetricWriter metricWriter) { | ||
| this.entityManager = entityManager; | ||
| this.metricWriter = metricWriter; | ||
| tweetValidationUtils = new TweetValidationUtils(); |
There was a problem hiding this comment.
Hi @hespoz I see now why do you have doubts about making this static or not static. Why haven't you injected here a TweetValidation instance from the spring context same way you have injected an EntityManager or a MetricWriter.
This way the TweetService is decoupled from the concrete implementation of TweetValidation, and at test time it can be mocked.
There was a problem hiding this comment.
Hi @rogervinas thats fair, actually I did not think about, but your approach make sense. I always create static classes for Mappers and Validations, because the memory reason I gave last thursday, but for sure I will rethink things hahahahah.
There was a problem hiding this comment.
@rogervinas regarding the injection of TweetValidationUtils, agree with you, we should leverage the IoC that spring or other frameworks offer to us. Just did not think about it when fix it.
Hi @rogervinas I have refactored the ValidateUtils to make it easy to extend and mock. Is not a static class anymore.