Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: remove node 14 and add node 20 support #614

Merged
merged 6 commits into from
Jun 1, 2023

Conversation

scolladon
Copy link
Owner

@scolladon scolladon commented May 24, 2023

Explain your changes


Remove installation test for node 14 as sfdx is compatible at least with the current LTS
Add installation test for node 20
Update the engine to point to the actual active current LTS (16)
Node 14 is deprecated from sfdx standpoint

Add dependency linter
Ensure sane dependency management and as light as possible package

@scolladon scolladon requested a review from mehdicherf as a code owner May 24, 2023 17:28
@github-actions
Copy link

github-actions bot commented May 24, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 6 0 0.1s
✅ COPYPASTE jscpd yes no 2.96s
✅ JAVASCRIPT eslint 69 0 0 6.68s
✅ JAVASCRIPT prettier 69 0 0 3.26s
✅ JSON eslint-plugin-jsonc 20 0 0 2.74s
✅ JSON jsonlint 20 0 0.22s
✅ JSON npm-package-json-lint yes no 0.49s
✅ JSON prettier 20 0 0 0.38s
✅ JSON v8r 20 0 11.98s
✅ MARKDOWN markdownlint 10 0 0 0.7s
✅ MARKDOWN markdown-link-check 10 0 12.23s
✅ MARKDOWN markdown-table-formatter 10 0 0 0.26s
✅ REPOSITORY checkov yes no 11.54s
✅ REPOSITORY gitleaks yes no 2.76s
✅ REPOSITORY git_diff yes no 0.02s
✅ REPOSITORY secretlint yes no 1.65s
✅ REPOSITORY trivy yes no 3.84s
✅ SPELL cspell 130 0 5.96s
✅ TYPESCRIPT eslint 2 0 0 1.76s
✅ YAML prettier 12 1 0 0.44s
✅ YAML v8r 12 0 17.53s
✅ YAML yamllint 12 0 0.26s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (b2e36e6) 100.00% compared to head (a5c7e36) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #614   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           32        32           
  Lines          898       889    -9     
=========================================
- Hits           898       889    -9     
Impacted Files Coverage Δ
src/utils/gitConstants.js 100.00% <ø> (ø)
src/utils/metadataConstants.js 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@scolladon scolladon force-pushed the build/add-dependency-linter branch 3 times, most recently from 28e4213 to 30c1250 Compare May 25, 2023 15:14
@scolladon scolladon changed the title build: add dependency linter build: remove node 14 and add node 20 support May 26, 2023
@scolladon scolladon force-pushed the build/add-dependency-linter branch 2 times, most recently from 68fa60d to 0e05721 Compare May 30, 2023 14:50
@scolladon scolladon force-pushed the build/add-dependency-linter branch from 07c4d14 to a5c7e36 Compare May 30, 2023 15:40
@codeclimate
Copy link

codeclimate bot commented May 30, 2023

Code Climate has analyzed commit a5c7e36 and detected 0 issues on this pull request.

View more on Code Climate.

@scolladon scolladon merged commit 9c5c8ee into main Jun 1, 2023
@scolladon scolladon deleted the build/add-dependency-linter branch June 1, 2023 12:41
@github-actions
Copy link

github-actions bot commented Jun 6, 2023

Shipped in release v5.21.0.
You can install the new version using the version number or the latest-rc channel

$ sfdx plugins:install sfdx-git-delta@latest-rc
$ sfdx plugins:install [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants