Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add WorkflowFlowAction to sub-object types #994

Closed
wants to merge 1 commit into from

Conversation

mcarvin8
Copy link
Contributor

@mcarvin8 mcarvin8 commented Jan 23, 2025

Explain your changes


Fixes the issues described in #993, which is WorkflowFlowAction being generated without the parent workflow name in the incremental package.xml.

Current release (6.2.0)

    <types>
        <members>Populate_PBA_from_Primary_CDM_User_record</members>
        <name>WorkflowFlowAction</name>
    </types>

When testing above fixes

    <types>
        <members>Account.Populate_PBA_from_Primary_CDM_User_record</members>
        <name>WorkflowFlowAction</name>
    </types>

Does this close any currently open issues?


closes #993

  • Jest tests added to cover the fix.
  • NUT tests added to cover the fix.
  • E2E tests added to cover the fix.

Any particular element that can be tested locally


I can provide a WorkflowFlowAction sample in your sfdx-git-delta reproduction playground repo.

See scolladon/sfdx-git-delta-reproduction-playground#10

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (5c4f60b) to head (239b41d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #994   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           44        44           
  Lines          994       994           
  Branches       105       105           
=========================================
  Hits           994       994           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@scolladon scolladon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM so far

I think we could add an integration test here.
IMHO, there is no need to include that into the end to end tests, as it is not a widely used feature.

src/constant/metadataConstants.ts Show resolved Hide resolved
src/service/typeHandlerFactory.ts Show resolved Hide resolved
Copy link

codeclimate bot commented Jan 23, 2025

Code Climate has analyzed commit 239b41d and detected 0 issues on this pull request.

View more on Code Climate.

@mcarvin8
Copy link
Contributor Author

Adding FlowAction to the integration test is passing

{826361B3-EF98-4DAD-811E-DD3BD2847FA2}

@mcarvin8 mcarvin8 changed the title fix: add WorkflowFlowAction to sub-object types fix: add WorkflowFlowAction to sub-object types Jan 23, 2025
Copy link
Owner

@scolladon scolladon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

__tests__/integration/services.test.ts Show resolved Hide resolved
@mcarvin8 mcarvin8 deleted the fix/flow-actions branch January 23, 2025 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WorkflowFlowAction Not Including Parent Workflow in Incremental Package.xml
2 participants