-
-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add WorkflowFlowAction
to sub-object types
#994
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #994 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 44 44
Lines 994 994
Branches 105 105
=========================================
Hits 994 994 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM so far
I think we could add an integration test here.
IMHO, there is no need to include that into the end to end tests, as it is not a widely used feature.
cf9af44
to
239b41d
Compare
Code Climate has analyzed commit 239b41d and detected 0 issues on this pull request. View more on Code Climate. |
WorkflowFlowAction
to sub-object types
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Explain your changes
Fixes the issues described in #993, which is
WorkflowFlowAction
being generated without the parent workflow name in the incremental package.xml.Current release (6.2.0)
When testing above fixes
Does this close any currently open issues?
closes #993
Any particular element that can be tested locally
I can provide a WorkflowFlowAction sample in your sfdx-git-delta reproduction playground repo.
See scolladon/sfdx-git-delta-reproduction-playground#10