Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ImageLab React] Added cross-env package to set Browser env. #176

Closed
wants to merge 2 commits into from
Closed

[ImageLab React] Added cross-env package to set Browser env. #176

wants to merge 2 commits into from

Conversation

achyutagupta
Copy link

@achyutagupta achyutagupta commented Jan 8, 2024

Description

Added a cross-env package in the node modules so that it can set env var BROWSER=none on running the command
'yarn dev' or 'npm run dev'.

image

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)
  • This change requires a documentation update

How Has This Been Tested?

On running the command 'yarn dev' or 'npm run dev', both the commands to start electron and react servers were starting properly and browser is set to none so that react server does not open browser, infact electron app is starting directly without any issue.

Also, include screenshots for verification and reviewing purpose.
image

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@abdullahranginwala
Copy link
Contributor

@achyutagupta Why are the 20,000 additions? Can you please look into that?

@achyutagupta
Copy link
Author

That's because of package-lock.json went into the commit. Should i remove that?

@achyutagupta achyutagupta closed this by deleting the head repository Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Image Lab React]: npm run dev -> "'BROWSER' is not recognized as an internal or external command."
2 participants