we should not modify the Promise object #33
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when modifying the Promise object we make the JS engine to act strange since it is not a native promise.
For instance: Promise.all(immu([Promise.Resolve(), Promise.resolve()])) throws an exception. Since immu will modify the Promises and wrap it inside an immu object when it shouldn't.
this is a very common scenario when we get data from a redux strore and we map to get only the id and do a fetchP with it. as a result:
const test = async() => {
const immuArr = immue ([1,2,3]);
const mapToPromise = immuArr.map((id) => fetchP(id));
await Promise.all(mapToPromise) // this will throw:
Method Promise.prototype.then called on incompatible receiver [object Promise]
}