Updated to be compatible with XHTML and HTML5 polyglot documents #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebaslogen
added a commit
to sebaslogen/bitcoin-price-ticker
that referenced
this pull request
Feb 9, 2014
|
merged to https://github.com/chezinut/coinwidget |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have modifed coin.js to fix issues that prevented CoinWidget from working with documents served as application/xhtml+xml. This will partially fix #2. I did not implement my changes as a jQuery plugin as suggested by the bug reporter due to the time that would be required to do so.
I also added ALT attributes to the IMG tags to make the widget a little more accessible to people with screen readers.