Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Scala 2.10/2.11, bump version to 2.0.0-SNAPSHOT #143

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

jozic
Copy link
Collaborator

@jozic jozic commented Nov 25, 2023

Drop Scala 2.10 and 2.11 and simplify artifacts resolution.
This works for some tests in https://github.com/scoverage/scoverage-maven-samples (those that use scala-maven-plugin, scalatest or surefire and Scala 2.12/2.13; specs2 maven plugin doesn't support latest spec2, sbt-compiler-maven-plugin tests fail on master)

@jozic jozic marked this pull request as ready for review November 25, 2023 06:11
@jozic jozic requested a review from ckipp01 November 25, 2023 06:11
@jozic
Copy link
Collaborator Author

jozic commented Dec 2, 2023

@ckipp01 do you mind checking this out?

Copy link
Member

@ckipp01 ckipp01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm totally fine with this approach. Just keep in mind that we will have to add some logic back in here to support Scala 3 since not all the artefacts are needed in that case -- since the compiler emits coverage date natively.

Thanks again for continuing to work on this @jozic .

@jozic
Copy link
Collaborator Author

jozic commented Dec 5, 2023

Thanks for review @ckipp01!
As of now Scala 3 is not "supported" and an attempt to use master branch code with Scala 3 will result in Skipping SCoverage execution - unsupported Scala version, so I do understand that for Scala 3 support we need to do more.
Which I would like to do after we release new version of the plugin.

@jozic jozic merged commit 569ca45 into master Dec 6, 2023
4 checks passed
@jozic jozic deleted the drop-2.10/2.11 branch December 6, 2023 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants