Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support messages with new line characters #126

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

dnlsng
Copy link

@dnlsng dnlsng commented Jan 3, 2017

Without this change, the bot would ignore any messages with new line characters.

This is useful in the case where you would want to do something like this:

@respond_to('(.*)', re.DOTALL)

to match all text including new lines.

I can't think of a case where this would be undesirable.

Without this change, the bot would ignore any messages with new line characters.
@jtatum
Copy link
Collaborator

jtatum commented Apr 8, 2017

Please add/update functional/unit tests for this behavior.

@lins05
Copy link
Collaborator

lins05 commented May 28, 2017

ping @dnlsng

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants