feat: [UEPR-57] migrate to react v18 #9311
Open
+4,086
−4,368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves:
UEPR-57
Changes:
scratch-guithe version is used. Updated studios routing. The previously used testing framework - Enzyme, won't be supported for react-18 and tests are migrated to React Testing Library (RTL). Most of the component tests rely on asserting props and state of the component, however RTL doesn't allow such assertions as what is intended to be tested by the library is only what the user would interact with. To bypass this there is a wrapper around the render method from RTL that searches the structure of the React element for the node that contains the props and state. We should discuss the approach before further updating the rest of the tests.DefaultPropsthat will be deprecated in future releases for functional components.