Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build for Xcode 16 #191

Merged
merged 3 commits into from
Nov 13, 2024
Merged

Build for Xcode 16 #191

merged 3 commits into from
Nov 13, 2024

Conversation

vijaysharm
Copy link
Contributor

No description provided.

@skz skz self-requested a review November 13, 2024 13:58
skz
skz approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@skz skz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good.

Project builds successfully for all targets.

Tested locally and tests are flaky, but after a few runs they all pass.

Approving since the goal of this PR is not test stabilization but xcode16 compatibility.

bwah
bwah approved these changes Nov 13, 2024
View reviewed changes
Copy link

@bwah bwah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vijaysharm vijaysharm enabled auto-merge November 13, 2024 19:43
@vijaysharm vijaysharm merged commit 789608f into main Nov 13, 2024
2 checks passed
@vijaysharm vijaysharm deleted the vijays/xcode_16 branch November 13, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skz skz skz approved these changes

@bwah bwah bwah approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vijaysharm @bwah @skz