Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allows for parameterizing entities to be marked as sendable #193

Merged
merged 3 commits into from
Nov 15, 2024
Merged

Allows for parameterizing entities to be marked as sendable #193

merged 3 commits into from
Nov 15, 2024

Conversation

vijaysharm
Copy link
Contributor

@vijaysharm vijaysharm commented Nov 13, 2024 •
edited
Loading

  • This PR allows you to create entities that are tagged with the Sendable protocol.

@vijaysharm vijaysharm force-pushed the vijays/make-entities-optionally-sendable branch from 27ed563 to ebc927a Compare November 15, 2024 11:50
@vijaysharm vijaysharm self-assigned this Nov 15, 2024
@vijaysharm vijaysharm requested a review from a team November 15, 2024 12:54
skz
skz reviewed Nov 15, 2024
View reviewed changes
Copy link
Contributor

@skz skz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, the code looks good 👍 . There's one small issue I found.

Lucid/Utils/AnySequence.swift Outdated Show resolved Hide resolved
@vijaysharm @skz
Update Lucid/Utils/AnySequence.swift
f00e183 
Co-authored-by: Stanisław Kożuchowicz <[email protected]>
skz
skz approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@skz skz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@vijaysharm vijaysharm merged commit dd82489 into main Nov 15, 2024
2 checks passed
@vijaysharm vijaysharm deleted the vijays/make-entities-optionally-sendable branch November 15, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skz skz skz approved these changes

Assignees

@vijaysharm vijaysharm

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vijaysharm @skz