[APT-9564] Clean up deprecated methods in ExoplayerExt #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -52,11 +51,11 @@ internal fun createRenderersFactory(context: Context): RenderersFactory = | |||
| RenderersFactory { eventHandler, _, audioRendererEventListener, _, _ -> | |||
| // Default audio sink taken from DefaultRenderersFactory. We need to provide it in order to enable offloading | |||
| // Note that we need to provide a new audio sink for each call - playback fails if we reuse the sink | |||
| val audioSink = DefaultAudioSink( | |||
| AudioCapabilities.getCapabilities(context), | |||
| DefaultAudioProcessorChain(), | |||
There was a problem hiding this comment.
I don't see an equivalent of this in the new code. Is that intentional?
BarryFruitman
approved these changes
Dec 6, 2023
kschults
force-pushed
the
karl/APT-9564-dash-progress
branch
from
2814259 to
62f57db
Compare
SeanoAndroid
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.