[APT-9568] Add model support for DRM info for streaming playback #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubeus90
approved these changes
Dec 21, 2023
NathanSass
reviewed
Dec 28, 2023
| @@ -28,6 +29,11 @@ internal class HlsMediaSourceGenerator @Inject constructor( | |||
| return DownloadHelper.createMediaSource(it.request, dataSourceFactory) | |||
| } | |||
| } | |||
|
|
|||
| if (request.drmInfo != null) { | |||
| Log.e(MediaSourceGenerator.TAG, "HLS does not currently support DRM") | |||
There was a problem hiding this comment.
@kschults Might be good to throw here cause we wouldn't want someone to think they are getting DRM protections and then still play the content. wyt?
There was a problem hiding this comment.
Damn, dude force ghosted in to call out a customer concern
:,) 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes in a license server and DRM headers to start playback of DRM-protected content
This does not provide support for offline playback (coming soon)