[APT-10449] Clients Call From Any Thread #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes no assumptions about what thread the client is calling ArmadilloPlayer from, aside from initialization. For those recently updating since 1.5.1, this should resolve any strange bugs from client behavior. Avoids making DRM system calls for content without DRM. This probably doesn't change anything.
kabliz
force-pushed
the
katherine/APT-10449-handler
branch
from
79eccfc to
b2f97df
Compare
kschults
requested changes
Sep 20, 2024
Armadillo/src/main/java/com/scribd/armadillo/ArmadilloPlayerChoreographer.kt
Show resolved
Hide resolved
kschults
approved these changes
Sep 20, 2024
Comment on lines
48
to
50
| val drmManager = if (request.drmInfo == null) { | ||
| drmSessionManagerProvider.get(mediaItem) | ||
| } else null |
There was a problem hiding this comment.
I wanted to double check that this is right - that if drmInfo is null, then we get a drmManager, but if it's not null then we set drmManager to null? From the desc, I was expecting the opposite.
FactoryFactory reflects design pattern used. Helper & Util names are an anti-pattern.
kschults
approved these changes
Sep 20, 2024
griffinfscribd
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes no assumptions about what thread the client is calling ArmadilloPlayer from, aside from initialization. For those recently updating since 1.5.1, this should resolve any strange bugs from client behavior.
Avoids making DRM system calls for content without DRM. This probably doesn't change anything.