Improve top error analytics #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sidkaria
force-pushed
the
sid/improve_error_analytics
branch
from
2b02057 to
582404e
Compare
kabliz
reviewed
Oct 18, 2024
Armadillo/src/main/java/com/scribd/armadillo/playback/ExoPlaybackExceptionExt.kt
Show resolved
Hide resolved
kabliz
approved these changes
Oct 18, 2024
sandymist
reviewed
Oct 18, 2024
Armadillo/src/main/java/com/scribd/armadillo/playback/PlayerEventListener.kt
Outdated
Show resolved
Hide resolved
sandymist
reviewed
Oct 18, 2024
|
|
||
| private fun DataSpec.toAnalyticsMap(context: Context): Map<String, String> { | ||
| return mapOf( | ||
| "uri" to uri.toString(), |
There was a problem hiding this comment.
In general it is ok to have .toString() but we won't be able to differentiate between value being null vs empty string right? We can bubble that up as well.
There was a problem hiding this comment.
This uri property is always non null -- also toString() returns "null" for null objects and "" for empty string
sandymist
reviewed
Oct 18, 2024
sandymist
reviewed
Oct 18, 2024
|
Looks good! Just had some minor comments. |
sidkaria
force-pushed
the
sid/improve_error_analytics
branch
from
ca8bea8 to
ca195fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add additional data for audio player error analytics: