Dynamic platform #608
Merged
Dynamic platform #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naure
reviewed
Nov 20, 2024
|
This approach is simple and a neat improvement. |
naure
approved these changes
Nov 20, 2024
naure
added a commit
that referenced
this pull request
Nov 21, 2024
Fix an invisible merge conflict between #611 and #608. Co-authored-by: Aurélien Nicolas <[email protected]>
naure
added a commit
that referenced
this pull request
Nov 21, 2024
_Issues #614 and #607_ Initialize memory with unconstrained prover hints. - It is practically identical to the zero-init circuit; just without the zero-init part. - The address range must be contiguous, but its size is dynamic. - The `u32` range check is already done by the LOAD and STORE circuits. e2e integration will be done in another PR. Need #608 to configure the address space. --------- Co-authored-by: Aurélien Nicolas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the platform dynamic:
Platforminto static methods, which replace some calls toCENO_PLATFORM.ProgramParamsstruct which stores the platform, the program size (no longer present in the type) and other useful params.ProgramPramsflow fromZKVMConstraintSystem, through theCircuitBuilder, through some of theTableConfigs and into the relevant table trait methods which implement the behavior we wanted to make dynamic.Observations:
VMand another for the constraint system.ProgramParamswhich is implicitly used in some constructors. This was done so as not to edit a lot of tests prematurely. While the default values should generally be compatible with the original intention of these test cases, it may be wise to remove the implicit defaults and force ourselves to choose params everywhere. This can be done in a subsequent PR.