Introduce Value::as_i32
#732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To help make #596 easier to read and reason about.
bgillesp
approved these changes
Dec 11, 2024
ceno_zkvm/src/uint.rs
Outdated
| @@ -684,6 +684,11 @@ impl<'a, T: Into<u64> + From<u32> + Copy + Default> Value<'a, T> { | |||
| self.as_u64() as u32 | |||
| } | |||
|
|
|||
| /// Convert the limbs to a u32 value | |||
There was a problem hiding this comment.
Copy-paste error: should be Convert the limbs to an i32 value
There was a problem hiding this comment.
Good catch!
10to4
pushed a commit
to 10to4/ceno
that referenced
this pull request
Dec 12, 2024
To help make scroll-tech#596 easier to read and reason about. Also introduce a few more conversion helpers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To help make #596 easier to read and reason about.
Also introduce a few more conversion helpers.