fix(async-ccc): print whole block hash and tx hash when failure

[colinlyguo]

1. Purpose or design rationale of this PR

Migrate the changes from #1092.

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

• fix: A bug fix

3. Deployment tag versioning

Has the version in params/version.go been updated?

• Yes

4. Breaking change label

Does this PR have the breaking-change label?

• This PR is not a breaking change

Summary by CodeRabbit

• New Features
  • Improved logging for block validation and CCC application failures to enhance error visibility.
• Bug Fixes
  • Updated logging format for block hashes to a more readable hexadecimal representation.
• Chores
  • Incremented version patch from 27 to 28 to indicate a new patch release.

[coderabbitai]

Walkthrough

The pull request introduces modifications across three files. In eth/backend.go, the logging functionality in the New function of the Ethereum struct is updated to log the hexadecimal representation of the block hash. The params/version.go file sees an increment in the VersionPatch constant from 27 to 28, reflecting a new patch release. Lastly, in rollup/pipeline/pipeline.go, a new logging statement is added to the cccStage method to warn when the application of the Circuit Capacity Checker fails, enhancing visibility without changing the existing logic.

Changes

File Path	Change Summary
eth/backend.go	Updated logging in the New function to log block hash as hexadecimal using b.Hash().Hex().
params/version.go	Incremented VersionPatch constant from 27 to 28.
rollup/pipeline/pipeline.go	Added a warning log in cccStage method for failed CCC application, including transaction hash.

Possibly related PRs

• feat(txpool): add logs to track txns #1046: This PR enhances logging functionality in the transaction pool, similar to the logging modification in the New function of the Ethereum struct in the main PR, both focusing on improving log clarity and readability.

Suggested reviewers

• omerfirmak
• Thegaram

Poem

In the code where rabbits hop,
Logs now shine, they never stop.
Block hashes gleam in hex so bright,
Version numbers take to flight.
With warnings clear, we’ll never stray,
Hooray for changes, hip-hip-hooray! 🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between ebb932e and 35a5d7f.

📒 Files selected for processing (1)

• params/version.go (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• params/version.go

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

rollup/pipeline/pipeline.go (1)

442-442: LGTM! Consider enhancing the error message.

The warning log is well-placed and includes essential information. However, consider making the message more descriptive.

-log.Warn("failed to apply CCC", "txHash", lastTxn.Hash().Hex(), "err", err)
+log.Warn("Circuit Capacity Checker validation failed", "txHash", lastTxn.Hash().Hex(), "err", err)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between d2fe42b and ebb932e.

📒 Files selected for processing (3)

• eth/backend.go (1 hunks)
• params/version.go (1 hunks)
• rollup/pipeline/pipeline.go (1 hunks)

✅ Files skipped from review due to trivial changes (1)

• params/version.go

🔇 Additional comments (1)

eth/backend.go (1)

205-205: LGTM! Improved log readability.

The change enhances log clarity by properly formatting the block hash in hexadecimal format. The warning message provides good context about the reorg action.