fix: seal block if single tx overflows #468
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Purpose or design rationale of this PR
After we run
ccc
and get an error, we revert all state changes:go-ethereum/miner/worker.go
Lines 893 to 898 in 626ae08
However,
ccc
internally maintains some state that is not reverted. As a result, if we continue to add txs to the block, we get such errors:This leads to discarding transactions unnecessarily. This PR changes the behaviour so that the
worker
does not continue to block any more transactions after a ccc error. We can change back to the original behaviour once this is fixed in the ccc.2. PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
3. Deployment tag versioning
Has the version in
params/version.go
been updated?4. Breaking change label
Does this PR have the
breaking-change
label?