feat(api, rawdb): batch clean skipped txs traces #501
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xmountaintop
force-pushed
the
reset_skipped_traces
branch
from
fe69e31 to
84270e1
Compare
0xmountaintop
force-pushed
the
store/skipped_traces
branch
from
528da52 to
7d908e6
Compare
0xmountaintop
force-pushed
the
reset_skipped_traces
branch
2 times, most recently
from
85caaeb to
5be70d9
Compare
Thegaram
reviewed
Sep 4, 2023
core/rawdb/accessors_skipped_txs.go
Outdated
Comment on lines
161
to
186
| mu.Lock() | ||
| defer mu.Unlock() |
There was a problem hiding this comment.
No need to lock, the other method only locks because all invocations to WriteSkippedTransaction (with a capital W) share a single counter.
0xmountaintop
force-pushed
the
reset_skipped_traces
branch
from
d47d9f7 to
ed1a10a
Compare
0xmountaintop
force-pushed
the
store/skipped_traces
branch
from
39d42a9 to
82483e5
Compare
0xmountaintop
force-pushed
the
reset_skipped_traces
branch
from
faa0a4b to
1b7db00
Compare
0xmountaintop
force-pushed
the
store/skipped_traces
branch
from
82483e5 to
86e2fb3
Compare
georgehao
reviewed
Sep 4, 2023
Thegaram
reviewed
Sep 7, 2023
| @@ -197,6 +197,11 @@ func WriteSkippedTransaction(db ethdb.Database, tx *types.Transaction, traces *t | |||
| } | |||
| } | |||
|
|
|||
| func ResetSkippedTransactionTracesByHash(db ethdb.Database, txHash common.Hash) { | |||
| stx := ReadSkippedTransaction(db, txHash) | |||
There was a problem hiding this comment.
Suggested change
| stx := ReadSkippedTransaction(db, txHash) | |
| stx := ReadSkippedTransaction(db, txHash) | |
| if stx == nil { | |
| return | |
| } |
Sorry, forgot about the nil case
There was a problem hiding this comment.
Return error can be better can let the caller know stx value is empty.
eth/api.go
Outdated
| return hashes, nil | ||
| } | ||
|
|
||
| // ResetSkippedTransactionTracesByHash reset a specified skipped tx's traces stored in db. |
There was a problem hiding this comment.
Suggested change
| // ResetSkippedTransactionTracesByHash reset a specified skipped tx's traces stored in db. | |
| // ResetSkippedTransactionTracesByHash resets a specified skipped tx's traces stored in db. |
mask-pp
reviewed
Sep 12, 2023
0xmountaintop
force-pushed
the
reset_skipped_traces
branch
from
f243e3e to
269bac1
Compare
0xmountaintop
changed the title
colinlyguo
previously approved these changes
Sep 20, 2023
0xmountaintop
force-pushed
the
reset_skipped_traces
branch
3 times, most recently
from
1bb1c04 to
10092a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Purpose or design rationale of this PR
After #500 we may store traces in DB, and we would like to clean them someday, because the trace size is nonnegligible.
2. PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
3. Deployment tag versioning
Has the version in
params/version.gobeen updated?4. Breaking change label
Does this PR have the
breaking-changelabel?