forked from ethereum/go-ethereum
-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rollup): sync finalized batches from L1 #515
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colinlyguo
force-pushed
the
feat-sync-finalized-batches-from-L1
branch
from
September 14, 2023 09:38
97dfaa9
to
ada6676
Compare
colinlyguo
changed the title
feat(rollup): sync finalized batches from L1
[WIP] feat(rollup): sync finalized batches from L1
Sep 14, 2023
colinlyguo
force-pushed
the
feat-sync-finalized-batches-from-L1
branch
7 times, most recently
from
September 15, 2023 06:42
935b1e1
to
8733519
Compare
colinlyguo
force-pushed
the
feat-sync-finalized-batches-from-L1
branch
6 times, most recently
from
September 15, 2023 12:29
ac753b7
to
8fecbed
Compare
colinlyguo
force-pushed
the
feat-sync-finalized-batches-from-L1
branch
from
September 17, 2023 12:03
8fecbed
to
21cbf3a
Compare
colinlyguo
force-pushed
the
feat-sync-finalized-batches-from-L1
branch
4 times, most recently
from
September 18, 2023 05:57
81304ba
to
8c09411
Compare
colinlyguo
force-pushed
the
feat-sync-finalized-batches-from-L1
branch
5 times, most recently
from
September 18, 2023 07:49
ff6f255
to
f7ca600
Compare
sync looks good in Mainnet so far:
updated: also tested. |
Thegaram
reviewed
Oct 26, 2023
Thegaram
reviewed
Oct 26, 2023
Thegaram
reviewed
Oct 26, 2023
add more detailed logs in crash case
Thegaram
previously approved these changes
Oct 26, 2023
colinlyguo
force-pushed
the
feat-sync-finalized-batches-from-L1
branch
from
October 26, 2023 18:06
e95cb9e
to
a4682ba
Compare
Thegaram
approved these changes
Oct 27, 2023
georgehao
approved these changes
Oct 27, 2023
0xmountaintop
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Purpose or design rationale of this PR
This PR adds a service to ensure the integrity and consistency of L2 data with the L1 data. When starting the node, it is initiated as a background process, guaranteeing the start procedure does not be blocked by
rollupSyncService
.Ref link (see the last requirement of
stage0
): https://l2beat.com/scaling/projects/arbitrum#stageUsage:
--rollup.verify
to enable.L1 state: Syncing with ScrollChain Contract
CommitBatch
,RevertBatch
, andFinalizeBatch
.CommitBatch
event: getbatch
->chunk range
->block ranges for each chunk
.BatchIndex
,BatchHash
,StateRoot
,WithdrawRoot
.L2 state: Reconstruct Batch Header to get Batch Hash
commitBatch
calldata.Consistency check
StateRoot
, andWithdrawRoot
with L1's.DB:
Unit tests:
2. PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
3. Deployment tag versioning
Has the version in
params/version.go
been updated?4. Breaking change label
Does this PR have the
breaking-change
label?