Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(miner): reduce rawdb calls for getting StartL1QueueIndex when inniting environment #550

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

GDdark
Copy link

@GDdark GDdark commented Nov 6, 2023

1. Purpose or design rationale of this PR

It seems that traceEnv.StartL1QueueIndex and env.nextL1MsgIndex are using the same value, so there is no need to repeatedly request the rawdb.

The presence of the QueueIndex has already been checked in CreateTraceEnv, so here we guarantee that the QueueIndex already exists

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change
  • Yes

@Thegaram Thegaram self-requested a review November 6, 2023 10:15
@GDdark GDdark changed the title Optimize: Reduce rawdb calls (worker) Optimize: Reduce rawdb calls Nov 7, 2023
@0xmountaintop 0xmountaintop self-requested a review November 7, 2023 05:53
@0xmountaintop 0xmountaintop changed the title (worker) Optimize: Reduce rawdb calls perf(miner): reduce rawdb calls for getting StartL1QueueIndex when inniting environment Nov 7, 2023
@Thegaram Thegaram merged commit a8a9dc8 into scroll-tech:develop Nov 8, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants