forked from ethereum/go-ethereum
-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add scroll_getTxBlockTraceOnTopOfBlock
API
#558
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xmountaintop
changed the title
Get block trace for call at
feat: add Nov 9, 2023
scroll_getBlockTraceForCallAt
API
0xmountaintop
force-pushed
the
getBlockTraceForCallAt
branch
from
November 9, 2023 10:35
a2d56fa
to
541fb57
Compare
colinlyguo
reviewed
Nov 9, 2023
colinlyguo
reviewed
Nov 9, 2023
Thegaram
reviewed
Nov 10, 2023
0xmountaintop
changed the title
feat: add
feat: add Nov 15, 2023
scroll_getBlockTraceForCallAt
APIscroll_getTxBlockTraceOnTopOfBlock
API
lispc
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Purpose or design rationale of this PR
Currently, if a tx encounters ccc overflow and is skipped, we can only use
debug_traceCall
to replay and get thestructLogs
. However, a tx'sstructLogs
is insufficient, or at least inconvenient, to analyze its ccc row consumption. This API add support for getting a wrapped blocktrace for a call/tx, at a given block's state.2. PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
3. Deployment tag versioning
Has the version in
params/version.go
been updated?4. Breaking change label
Does this PR have the
breaking-change
label?