Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add scroll_getTxBlockTraceOnTopOfBlock API #558

Merged
merged 15 commits into from
Nov 20, 2023

Conversation

0xmountaintop
Copy link

@0xmountaintop 0xmountaintop commented Nov 9, 2023

1. Purpose or design rationale of this PR

Currently, if a tx encounters ccc overflow and is skipped, we can only use debug_traceCall to replay and get the structLogs. However, a tx's structLogs is insufficient, or at least inconvenient, to analyze its ccc row consumption. This API add support for getting a wrapped blocktrace for a call/tx, at a given block's state.

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change
  • Yes

@0xmountaintop 0xmountaintop changed the title Get block trace for call at feat: add scroll_getBlockTraceForCallAt API Nov 9, 2023
@0xmountaintop 0xmountaintop marked this pull request as ready for review November 9, 2023 10:35
@0xmountaintop 0xmountaintop changed the title feat: add scroll_getBlockTraceForCallAt API feat: add scroll_getTxBlockTraceOnTopOfBlock API Nov 15, 2023
@0xmountaintop 0xmountaintop merged commit f4b247d into develop Nov 20, 2023
5 checks passed
@0xmountaintop 0xmountaintop deleted the getBlockTraceForCallAt branch November 20, 2023 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants