Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce HashedStorageProvider #46

Merged

Conversation

frisitano
Copy link
Collaborator

Overview

This PR introduces the HashedStorageProvider which can be used to created HashedStrage using the KeyHasher from the StateCommitment object. It should be reviewed after #45.

greged93
greged93 previously approved these changes Dec 3, 2024
Copy link
Collaborator

@greged93 greged93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one nit on trait bound ordering

crates/stages/stages/src/stages/execution.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@greged93 greged93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@frisitano frisitano merged commit 9cf7d14 into scroll-tech:scroll Dec 3, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants