Update contract verification page for etherscan and mainnet #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for scroll-documentation ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
isabellewei
commented
Nov 17, 2023
Comment on lines
112
to
116
| {/* <Aside type="danger" title="Warning"> | ||
| Our Blockscout instance currently has inconsistent behavior in verifying contracts with Foundry. We're working on a | ||
| fix, along with other stability improvements. Don't hesitate to come ask for help [on | ||
| Discord](https://discord.com/channels/853955156100907018/1028102371894624337) though. | ||
| </Aside> | ||
| </Aside> */} |
There was a problem hiding this comment.
do we still want to include this here?
dghelm
previously approved these changes
Nov 17, 2023
| Most smart contract tooling has plugins for verifying your contracts easily on Etherscan. Blockscout supports Etherscan's contract verification APIs, and it's straightforward to use these tools with the Scroll Sepolia Testnet. | ||
| Most smart contract tooling has plugins for verifying your contracts easily on Etherscan. Blockscout supports Etherscan's contract verification APIs, so it's straightforward to use these tools using the APIs of either of these block explorers. | ||
|
|
||
| | Network | Scroll Scroll | Sepolia | |
| --- | ||
|
|
||
| import Aside from "../../../../components/Aside.astro" | ||
| import ClickToZoom from "../../../../components/ClickToZoom.astro" | ||
| import verify1 from "./_images/verify1.png" | ||
| import CodeSample from "../../../../components/CodeSample/CodeSample.astro" | ||
|
|
||
| After deploying your smart contracts, it's important to verify your code on [our block explorer](https://scrollscan.com/) or the [Sepolia block explorer](https://sepolia-blockscout.scroll.io). | ||
| After deploying your smart contracts, it's important to verify your code on our block explorers. This can be done in an automated way using your developer tooling or the Web UI. |
There was a problem hiding this comment.
I'm wondering if "our" is right if we're not running Scrollscan and other blockexplorers might want visibility on this page.
"on a block explorer"
| | Network | Scroll Scroll | Sepolia | | ||
| | ---------- | -------------------------------- | ---------------------------------------- | | ||
| | Scrollscan | https://api.scrollscan.com/api | https://api-sepolia.scrollscan.com/api | | ||
| | Blockscout | https://blockscout.scroll.io/api | https://sepolia-blockscout.scroll.io/api | |
There was a problem hiding this comment.
Do we even want to emphasize Blockscout? For the most part we consider it an internal tool and don't want developers defaulting to using it for contract verification.
There was a problem hiding this comment.
Actually, for now let's leave it.
Comment on lines
112
to
116
| {/* <Aside type="danger" title="Warning"> | ||
| Our Blockscout instance currently has inconsistent behavior in verifying contracts with Foundry. We're working on a | ||
| fix, along with other stability improvements. Don't hesitate to come ask for help [on | ||
| Discord](https://discord.com/channels/853955156100907018/1028102371894624337) though. | ||
| </Aside> | ||
| </Aside> */} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add instructions for contract verification with Etherscan and mainnet