Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(frozen) v0.3: default DEGREE=20 #121

Merged
merged 94 commits into from
Apr 9, 2023
Merged

(frozen) v0.3: default DEGREE=20 #121

merged 94 commits into from
Apr 9, 2023

Conversation

lispc
Copy link
Collaborator

@lispc lispc commented Mar 27, 2023

changes:

  1. set default super circuit degree to 20, fixing "rw not enough" panic. Proving time increased to ~30min.
  2. use uncompressed point in params. Loading time of params26 reduce from 10minutes to 10seconds in a 8 core server. But file size increased from 4G to 8G.
  3. decouple version of params and circuit(vk, verifier.sol) since they actually are not same thing.
  4. re-enable zktrie in super circuit. Need to deploy [Fix] deletion proof should be collected in log tracing go-ethereum#247 first!
  5. use latest version of public input hashing mechanism

release files:

 $ aws  --profile default s3 ls s3://circuit-release/circuit-release/params-0320/
2023-03-31 01:23:08  134217988 params20
2023-03-31 01:23:08 8589934852 params26
2023-03-31 01:23:08        202 sha256sum
[  1:27AM ]  [ lispc@dev1:~/into_s3/circuit-release ]
 $ aws  --profile default s3 ls s3://circuit-release/circuit-release/release-v0.3/
2023-03-31 01:21:55       8263 full_proof.data
2023-03-31 01:21:55        328 sha256sum
2023-03-31 01:21:55      36995 verifier.sol
2023-03-31 01:21:55        744 verify_circuit.vkey

@lispc
Copy link
Collaborator Author

lispc commented Mar 27, 2023

oh substrate upgrade their ecdsa dependency... the Cargo.lock is broken now...

@kunxian-xia kunxian-xia self-requested a review March 30, 2023 09:41
@lispc lispc changed the title (wip) v0.3: new public input format (frozen) v0.3: new public input format Mar 31, 2023
@lispc lispc changed the title (frozen) v0.3: new public input format (frozen) v0.3: DEGREE=20 Mar 31, 2023
@lispc lispc changed the title (frozen) v0.3: DEGREE=20 (frozen) v0.3: default DEGREE=20 Mar 31, 2023
@lispc
Copy link
Collaborator Author

lispc commented Mar 31, 2023

TODO:'

tag "v0.3" after gpu tests pass

@kunxian-xia
Copy link
Contributor

We should update the contrib/download_params.sh script as it's out-dated.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can update the version in Cargo.tomls to 0.3.0

@lispc lispc merged commit 78ab7a7 into main Apr 9, 2023
@lispc lispc deleted the v0.3 branch April 9, 2023 09:17
@lispc lispc restored the v0.3 branch May 10, 2023 09:31
@0xmountaintop 0xmountaintop deleted the v0.3 branch May 16, 2023 07:31
@lispc lispc restored the v0.3 branch May 17, 2023 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants