feat: return VKs from chunk and batch provers #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silathdiir
force-pushed
the
feat/gen-pks-at-beginning
branch
from
7cf4a8d to
ee3e02a
Compare
silathdiir
changed the title
gen_pk flag when init chunk-provergen_pk flag when init chunk-prover
silathdiir
force-pushed
the
feat/gen-pks-at-beginning
branch
from
f7b1fca to
29abb4e
Compare
silathdiir
changed the title
gen_pk flag when init chunk-prover
silathdiir
changed the title
silathdiir
changed the title
silathdiir
force-pushed
the
feat/gen-pks-at-beginning
branch
from
9eb6e1f to
ae5e1c1
Compare
silathdiir
changed the title
silathdiir
changed the title
lispc
reviewed
Sep 2, 2023
prover/src/common/prover/chunk.rs
Outdated
| impl Prover { | ||
| pub fn gen_chunk_pk(&mut self, output_dir: Option<&str>) -> Result<()> { |
There was a problem hiding this comment.
is this function still relevant? or just keep it here in case for future use?
There was a problem hiding this comment.
Delete this function in commit 66f6d56.
lispc
previously approved these changes
Sep 2, 2023
lispc
approved these changes
Sep 3, 2023
cyphersnake
pushed a commit
to cyphersnake/scroll-prover
that referenced
this pull request
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related scroll PR scroll-tech/scroll#894
Add VK files to assets of chunk and batch provers.
Read VKs when init provers.
Check and clear init VK with generated VK (from PK) after generates for the first time. Log an error if not equal.
Add a new test trace
prover/tests/extra_traces/new.json(withstartL1QueueIndex) for chunk-tests and aggregation-tests.Delete Dockerfile.
Test