Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix typos #1013

Merged
merged 4 commits into from
Dec 13, 2023
Merged

docs: fix typos #1013

merged 4 commits into from
Dec 13, 2023

Conversation

momodaka
Copy link
Contributor

Purpose or design rationale of this PR

fix typo

tranfer ETH to sender -> transfer ETH to sender

MaxHeight is the maixium possible -> MaxHeight is the maximum possible

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

  • No, this PR doesn't involve a new deployment, git tag, docker image tag
  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change
  • Yes

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8cb750e) 48.90% compared to head (da23492) 48.87%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1013      +/-   ##
===========================================
- Coverage    48.90%   48.87%   -0.03%     
===========================================
  Files          158      158              
  Lines        12710    12676      -34     
===========================================
- Hits          6216     6196      -20     
+ Misses        6064     6053      -11     
+ Partials       430      427       -3     
Flag Coverage Δ
bridge-history-api 11.11% <ø> (ø)
contracts 53.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@georgehao georgehao merged commit db07180 into scroll-tech:develop Dec 13, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants