Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(contracts): new zktrie verifier #1017

Merged
merged 9 commits into from
Jan 23, 2024
Merged

Conversation

zimpha
Copy link
Member

@zimpha zimpha commented Nov 28, 2023

Purpose or design rationale of this PR

This PR implements the zktrie verifier based on latest zktrie code.

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • feat: A new feature

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

  • No, this PR doesn't involve a new deployment, git tag, docker image tag

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change

@zimpha zimpha self-assigned this Nov 28, 2023
Copy link

LCOV of commit 111a0bd during Contracts #140

Summary coverage rate:
  lines......: 54.0% (1075 of 1990 lines)
  functions..: 67.0% (235 of 351 functions)
  branches...: no data found

Files changed coverage rate: n/a

noel2004
noel2004 previously approved these changes Dec 21, 2023
Copy link
Member

@noel2004 noel2004 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for some nitpicks

Copy link

codecov bot commented Dec 21, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (69224eb) 56.45% compared to head (ba3265d) 56.55%.

Files Patch % Lines
...ts/src/L1/rollup/ScrollChainCommitmentVerifier.sol 0.00% 2 Missing ⚠️
...ontracts/src/libraries/verifier/ZkTrieVerifier.sol 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1017      +/-   ##
===========================================
+ Coverage    56.45%   56.55%   +0.10%     
===========================================
  Files          149      149              
  Lines        11087    11067      -20     
===========================================
  Hits          6259     6259              
+ Misses        4406     4386      -20     
  Partials       422      422              
Flag Coverage Δ
contracts 57.54% <0.00%> (+0.57%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

noel2004
noel2004 previously approved these changes Dec 21, 2023
@icemelon icemelon merged commit c68f428 into develop Jan 23, 2024
11 checks passed
@icemelon icemelon deleted the feat/new_zktrie_verifier branch January 23, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants