Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: split the coordinator cron to single process #995

Merged
merged 19 commits into from
Oct 26, 2023

Conversation

georgehao
Copy link
Member

@georgehao georgehao commented Oct 19, 2023

Purpose or design rationale of this PR

Describe your change. Make sure to answer these three questions: What does this PR do? Why does it do it? How does it do it?

Because coordinator cron couldn't deploy duplicately. so need split the cron task as single process

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

  • No, this PR doesn't involve a new deployment, git tag, docker image tag
  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change
  • Yes

@georgehao georgehao changed the title feat: split the coordinator cron to single process (WIP)feat: split the coordinator cron to single process Oct 19, 2023
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #995 (711ec82) into develop (2102e16) will decrease coverage by 0.15%.
Report is 1 commits behind head on develop.
The diff coverage is 16.66%.

❗ Current head 711ec82 differs from pull request most recent head 0ff194a. Consider uploading reports for the commit 0ff194a to get more accurate results

@@             Coverage Diff             @@
##           develop     #995      +/-   ##
===========================================
- Coverage    48.14%   47.99%   -0.15%     
===========================================
  Files          100      101       +1     
  Lines        10591    10640      +49     
===========================================
+ Hits          5099     5107       +8     
- Misses        5070     5110      +40     
- Partials       422      423       +1     
Flag Coverage Δ
common 54.86% <ø> (-0.09%) ⬇️
coordinator 18.91% <16.66%> (-0.03%) ⬇️
database 42.85% <ø> (ø)
rollup 66.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
common/utils/simulation.go 0.00% <ø> (ø)
coordinator/cmd/api/app/mock_app.go 0.00% <0.00%> (ø)
coordinator/cmd/api/app/app.go 13.15% <20.00%> (ø)
coordinator/cmd/cron/app/app.go 16.98% <16.98%> (ø)

... and 1 file with indirect coverage changes

common/utils/simulation.go Outdated Show resolved Hide resolved
@mask-pp
Copy link
Contributor

mask-pp commented Oct 19, 2023

Please update readme doc in coordinator folder.

@georgehao georgehao changed the title (WIP)feat: split the coordinator cron to single process feat: split the coordinator cron to single process Oct 19, 2023
mask-pp
mask-pp previously approved these changes Oct 20, 2023
Copy link
Contributor

@0xmountaintop 0xmountaintop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

coordinator_cron doesn't require libzkp

so we don't need to build libzkp in coordinator_cron docker
and can remove libzkp dependency for coordinator_cron (and no need coordinator_cron_skip_libzkp)

coordinator/README.md Outdated Show resolved Hide resolved
@georgehao
Copy link
Member Author

coordinator_cron doesn't require libzkp

so we don't need to build libzkp in coordinator_cron docker and can remove libzkp dependency for coordinator_cron (and no need coordinator_cron_skip_libzkp)

fixed

coordinator/Makefile Outdated Show resolved Hide resolved
0xmountaintop
0xmountaintop previously approved these changes Oct 24, 2023
Copy link
Contributor

@0xmountaintop 0xmountaintop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mask-pp
mask-pp previously approved these changes Oct 25, 2023
@0xmountaintop 0xmountaintop added the bump-version Bump the version tag for deployment label Oct 25, 2023
@github-actions github-actions bot dismissed stale reviews from 0xmountaintop and mask-pp via 0ff194a October 25, 2023 08:44
@0xmountaintop
Copy link
Contributor

we'd better still bump the version for this PR, otherwise the tag will conflict

@georgehao
Copy link
Member Author

we'd better still bump the version for this PR, otherwise the tag will conflict

ok

@0xmountaintop 0xmountaintop merged commit 50040a1 into develop Oct 26, 2023
@0xmountaintop 0xmountaintop deleted the feat/split_coordinator_cron branch October 26, 2023 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump-version Bump the version tag for deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants