-
Notifications
You must be signed in to change notification settings - Fork 617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: split the coordinator cron to single process #995
Conversation
…scroll into feat/split_coordinator_cron
Codecov Report
@@ Coverage Diff @@
## develop #995 +/- ##
===========================================
- Coverage 48.14% 47.99% -0.15%
===========================================
Files 100 101 +1
Lines 10591 10640 +49
===========================================
+ Hits 5099 5107 +8
- Misses 5070 5110 +40
- Partials 422 423 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Please update readme doc in coordinator folder. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
coordinator_cron
doesn't require libzkp
so we don't need to build libzkp
in coordinator_cron
docker
and can remove libzkp
dependency for coordinator_cron
(and no need coordinator_cron_skip_libzkp
)
fixed |
…scroll into feat/split_coordinator_cron
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
0ff194a
we'd better still bump the version for this PR, otherwise the tag will conflict |
ok |
Purpose or design rationale of this PR
Describe your change. Make sure to answer these three questions: What does this PR do? Why does it do it? How does it do it?
Because coordinator cron couldn't deploy duplicately. so need split the cron task as single process
PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
Deployment tag versioning
Has
tag
incommon/version.go
been updated or have you addedbump-version
label to this PR?Breaking change label
Does this PR have the
breaking-change
label?